clawpack / amrclaw

AMR version of Clawpack
http://www.clawpack.org
BSD 3-Clause "New" or "Revised" License
26 stars 45 forks source link

Fix restart frame number when output_t0 is True #281

Closed rjleveque closed 12 months ago

rjleveque commented 12 months ago
Fix src/Nd/restrt.f so that frame number is not advanced if output_t0 is True

In this case it re-writes the last frame from the original calculation
when restarting, and it should reuse that frame number.  For historical
reasons the frame number is called matlabu, stored in amr_module.f90
mjberger commented 12 months ago

it's not correct. I was about to comment.

Can you regress? — Marsha

On Sep 14, 2023, at 11:18 AM, Kyle Mandli @.***> wrote:

Merged #281 https://github.com/clawpack/amrclaw/pull/281 into master.

— Reply to this email directly, view it on GitHub https://github.com/clawpack/amrclaw/pull/281#event-10373757875, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGUGC7BGENJVAMLHIC5AG3X2MN5VANCNFSM6AAAAAA4XOFCTI. You are receiving this because you are subscribed to this thread.

mandli commented 12 months ago

Yes, but what was not correct? Does it not work?

mjberger commented 12 months ago

gives wrong frame number in the output_t0 case false.

— Marsha

On Sep 14, 2023, at 11:30 AM, Kyle Mandli @.***> wrote:

Yes but was not correct? Does it not work?

— Reply to this email directly, view it on GitHub https://github.com/clawpack/amrclaw/pull/281#issuecomment-1719679526, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGUGC7SGBJ7YCAK6TJHDXTX2MPI3ANCNFSM6AAAAAA4XOFCTI. You are receiving this because you commented.

mandli commented 12 months ago

Does amr2 need to be modified?

mjberger commented 12 months ago

that's how I did it, but I"m trying to fix it without that using only restrt.

I have a meeting. I"ll have to do it this afternoon.

— Marsha

On Sep 14, 2023, at 11:36 AM, Kyle Mandli @.***> wrote:

Does amr2 need to be modified?

— Reply to this email directly, view it on GitHub https://github.com/clawpack/amrclaw/pull/281#issuecomment-1719690034, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGUGC5YHJHZKYDLJXX6W6TX2MQABANCNFSM6AAAAAA4XOFCTI. You are receiving this because you commented.

mandli commented 12 months ago

Reverting this for the time being along with the equivalent GeoClaw PR then.