search

clawpack / apps

Repository of applications of Clawpack and related codes
Other
11 stars 40 forks source link

Tide Module Example Jupyter Notebook #105

Open socoyjonathan opened 2 years ago

socoyjonathan commented 2 years ago

Let me know if apps/geoclaw is the desired location for tide module!

rjleveque commented 2 years ago

apps/notebooks/geoclaw seems like a good place for this, but I think the same notebook is also in https://github.com/clawpack/tidal-examples/pull/3? Maybe having this basic example both places makes sense, but might be harder to maintain.

I noted in that tidal-examples PR that two different versions of tide.py are used, and in this PR the local tide.py does not exist, so the first import statement fails and should presumably be replaced by from clawpack.geoclaw import tide

mandli commented 2 years ago

We should figure out which makes more sense, having both is not a good idea. I had suggested to move the tide.py to GeoClaw itself rather than having it in the apps repository. We probably should just close the original PR in favor of the one that will use the module in GeoClaw.