Closed rjleveque closed 9 years ago
+1 for doing this now, as part of 5.2.
I think I just spent more time clicking through github pages than actually changing and pushing source. As long as we are all good with this the PRs await.
Travis fails in classic, I think because you added more precision to the output format and so the regression data needs to be updated accordingly for comparison purposes.
Thanks for doing this, I think you caught every line I'd looked at yesterday. I should have just made the changes!
On Wed, Jun 11, 2014 at 1:21 PM, Kyle Mandli notifications@github.com wrote:
I think I just spent more time clicking through github pages than actually changing and pushing source. As long as we are all good with this the PRs await.
— Reply to this email directly or view it on GitHub https://github.com/clawpack/classic/issues/61#issuecomment-45794390.
Added the new regression data, now Travis tests are passing.
Fixed by PR #62
This is an issue in classic, amrclaw, and geoclaw where the output routines use a format to print only 4 values (or sometimes 5 or 10) to a line in fort.q and fort.a files.
These should all be cleaned up to a uniform format such as
so there is never danger of lines of output being broken.
See the discussion at clawpack/pyclaw#363, and much follow up on the claw-dev mailing list,
https://groups.google.com/forum/?fromgroups#!searchin/claw-dev/363/claw-dev/arv_a220obI/9cidhzs-3tgJ where we decided this was a good idea but to put it off to 6.0.
But now I don't see any reason to put it off and we just ran into this issue again.