clawpack / clawutil

General utility programs
BSD 3-Clause "New" or "Revised" License
10 stars 31 forks source link

making runclaw easier to call direct from python #136

Closed bolliger32 closed 5 years ago

bolliger32 commented 5 years ago

The reason for this PR was that we were trying to run multiple models, each with a single thread, all sharing a process. The reason for this is some weird memory limit issues running w/ kubernetes on Google Cloud. This is probably an edge case, but we were having issues with all of the chdir calls in runclaw b/c all threads were sharing the same working directory.

I worked on getting rid of the directory switching behavior to meet our purposes. It's possible this is overengineering things, but I think it also helped clean up runclaw in the process. Let me know what you think. I'm happy to keep this on our fork and out of the main clawpack code if you'd rather not mess with the current structure of runclaw

Note that in order for these changes to pass tests, we also need a PR that I'm about to file for geoclaw and amrclaw, since it requires some changes to the write methods for various geoclaw and amrclaw data objects.

A couple notable changes I made:

mandli commented 5 years ago

@rjleveque Can you take a look at this to make sure I did not miss anything in this review?