clawpack / clawutil

General utility programs
BSD 3-Clause "New" or "Revised" License
10 stars 31 forks source link

Testing framework #91

Closed rjleveque closed 8 years ago

rjleveque commented 8 years ago

Implemented so changes to ClawpackRegressionTest.check_gauges to work better with multiple gauges when OpenMP is used to address #89.

Some changes:

There's a test case in dev/advection_3d_swirl. nosetests should work with the data in that directory. Try changing a gauge location in setrun.py if you want to see the error output.

I'd suggest we eventually modify the way frame comparisons are done to give a more useful error message and help figure out what might have changed if the assertion fails.

Note: if this gets merged in, Travis tests in amrclaw and geoclaw will fail until the gauge regression data is updated to match what's now expected.

mandli commented 8 years ago

This all looks good to me. I also raised an issue regarding the frame comparisons.