Change When Gauges are Recorded

clawpack / geoclaw

Version of Clawpack for geophysical waves and flows

http://www.clawpack.org/geoclaw

BSD 3-Clause "New" or "Revised" License

76 stars 87 forks source link

Open mandli opened 6 years ago

mandli commented 6 years ago

Currently gauge data is recorded before a time step is taken. This decision will catch the initial condition but has two drawbacks:

the last time point is never captured and
if aux fields are not set in setaux but somewhere else such as b4step these values will be incorrectly recorded every regridding time.

Note that the latter of these is only an issue to how the gauges record aux values and does not impact the actual time stepping.

mandli commented 6 years ago

Couple of other thoughts:

The primary idea here would be to move the call to update_gauges to after stepgrid is called. We should also add update_gauges to also hit the initial time step.
This will break any test that relies on gauges.
This should be back-ported to AMRClaw as well.

mandli commented 5 years ago

This needs to be checked to see if this works now.