search

clawpack / pyclaw

PyClaw is a Python-based interface to the algorithms of Clawpack and SharpClaw. It also contains the PetClaw package, which adds parallelism through PETSc.
http://www.clawpack.com/pyclaw
BSD 3-Clause "New" or "Revised" License
164 stars 99 forks source link

Get rid of some compile-time warnings. #712

Closed ketch closed 6 months ago

ketch commented 1 year ago

Avoid static array size in SW sphere example. Update use of numpy C API in weno code.

ketch commented 1 year ago

Thanks to Lisandro Dalcin for contributing this patch, which removes several warnings that were being raised at compile time.

rgommers commented 6 months ago

Merging this PR seems useful and fairly urgent, since a lot of direct field access in reconstruct.c is going to break when NumPy 2.0 is released (probably within the next month). Is there a reason that this can't be merged?

ketch commented 6 months ago

Thanks for the reminder! I had forgotten about it...