search

clawpack / riemann_book

An interactive book about the Riemann problem for hyperbolic PDEs, using Jupyter notebooks.
BSD 3-Clause "New" or "Revised" License
264 stars 95 forks source link

Make animation fixes #208

Closed rjleveque closed 4 years ago

rjleveque commented 4 years ago

Some updates to how animations are created: have the demos return anim generated by animation.to_jshtml and then call HTML(anim) in the notebook or write it out as an html file in Make_html_animations.ipynb. Also modified some of the headings and text for the last examples in Burgers, and added hide tags to the cells showing the animations.

Possibly some conflict with changes to Burgers in #205? I doubt it, but I haven't checked.

ketch commented 4 years ago

I notice several lines that are commented out -- do those get uncommented when generating another format of the book?

rjleveque commented 4 years ago

I guess you mean the lines

#video_html = anim.to_html5_video()

Those have now been removed -- thanks, I was testing it first and forgot to clean up.

maojrs commented 4 years ago

It seems there was not much of a conflict to merge with master (changes in #205), so I merged it. The notebooks seem to be working fine and include all the changes. I think this pull request can be merged now.