Closed rjleveque closed 4 years ago
These changes look good to me. I think we should remove the 3D Euler equations, since we don't even talk about shear waves in the Riemann solution, and interested readers can go to the other books we cite.
I removed 3D Euler and slightly reworked the paragraph around the 1D equations, and eliminated one section heading.
Some changes:
Nonconvex_scalar
:Euler
andShallow_tracer
)Euler
:exact_solvers
codes, and changed interactive Riemann solver for Euler so it has different data than Sod, and so it's clear what these data are in the call toeuler_demo1
, to improve what shows up in the pdf file.One question in
Euler
: do we really want to write out the full 3D Euler equations, as we do in this notebook? We don't do this for any other problem, although we could for acoustics, SWE, etc. Maybe it's useful to see but perhaps just distracting since we don't discuss it further.