search

clawpack / riemann_book

An interactive book about the Riemann problem for hyperbolic PDEs, using Jupyter notebooks.
BSD 3-Clause "New" or "Revised" License
264 stars 95 forks source link

New material added to Approximate_solvers #215

Closed rjleveque closed 4 years ago

rjleveque commented 4 years ago

I added quite a bit to Approximate_solvers, let me know what you think.

I thought it would be good to say a bit more about FV methods, Godunov in particular, and how the Riemann solver is used. And I rewrote it to remove the fluctuations amdq and apdq since we never use these later and people often find that notation confusing. Instead I allude to them in the context of nonconservative problems but focus more on flux-differencing form and interface fluxes.

I'm still going through the following chapters to make sure notation is consistent with these changes, and have some other things to fix in those.

ketch commented 4 years ago

This looks very good to me, modulo a few minor comments above. This will make the book significantly more self-contained and provides better motivation for all of Part II.

rjleveque commented 4 years ago

Thanks for reviewing. I'll make these edits.