search

clawpack / riemann_book

An interactive book about the Riemann problem for hyperbolic PDEs, using Jupyter notebooks.
BSD 3-Clause "New" or "Revised" License
264 stars 95 forks source link

Fix bugs in shallow water solver. #242

Closed ketch closed 2 years ago

ketch commented 2 years ago

Typo led to mislabeling of 1-wave as rarefaction and no labeling of 2-wave in some cases.

Incorrect indexing (right=2) when the tracer is included led to incorrect coloring of the 2-wave and incorrect placement of dashed/solid parts of the integral curve or Hugoniot locus.

Thanks to @carlosmunozmoncayo for spotting one of these issues.

ketch commented 2 years ago

I took this opportunity to also improve the text in a couple of places.

rjleveque commented 2 years ago

Looks good to me, thanks!