search

clawpack / visclaw

Clawpack visualization tools
http://www.clawpack.org
BSD 3-Clause "New" or "Revised" License
29 stars 48 forks source link

Gauge interp #148

Closed rjleveque closed 9 years ago

rjleveque commented 9 years ago

Utility module for reading gauge data and interpolating to arbitrary times.

mandli commented 9 years ago

Looks good to me although I am wondering if this would be better to have in AMRClaw or GeoClaw and separate out the plotting?

rjleveque commented 9 years ago

Or maybe in clawutil, since eventually we should add gauges to the classic code as well?

mandli commented 9 years ago

Yeah, that would be better perhaps. PyClaw also has some idea of gauges as well but I am not certain that these routines would be as useful.

ketch commented 9 years ago

Thinking long-term, it seems like plotdata.getgauge should live in some (reorganized) IO module.

I've been using Pandas more and more lately, and it might be nice to read gauges into a Pandas.Series (time series) object. Those have a built-in interpolate function, as well as many other niceties. Of course, depending on Pandas would be a major decision but it's becoming as widely used as numpy or matplotlib.

(No need to figure this out before merging the present PR, of course)

mandli commented 9 years ago

So leave this here with the intention of moving all the gauge IO somewhere else when we can separate out this type of functionality more broadly?

ketch commented 9 years ago

That sounds good to me.

rjleveque commented 9 years ago

Seems reasonable to me, and it would be nice to re-think all the I/O at some point.

I haven't used Pandas, but glancing at the tutorial, it looks very useful, http://pandas.pydata.org/pandas-docs/dev/10min.html

mjberger commented 9 years ago

can I add a word of caution: most difficulty of people downloading clawpack is versionitis in python, or other rapidly changing packages. How stable is this - does it really add enough to complicate the system further?

On Mar 10, 2015, at 11:05 AM, Randall J. LeVeque notifications@github.com wrote:

Seems reasonable to me, and it would be nice to re-think all the I/O at some point.

I haven't used Pandas, but glancing at the tutorial, it looks very useful, http://pandas.pydata.org/pandas-docs/dev/10min.html

— Reply to this email directly or view it on GitHub.

ketch commented 9 years ago

@mjberger I strongly agree with your concerns. Pandas is still evolving and is version 0.x. But it is about as stable as scipy and I believe has a more robust installation procedure. Anyone with a scientific Python stack almost certainly has it already.

I also wonder whether introducing additional new data structures is a good idea -- it means one more thing people have to learn before using the code. But if we could replace our own custom data structures with others that are developed and maintained by a much larger community, as long as they still serve our purposes well then that might be really useful. Anyway, something to discuss next week.