search

clawpack / visclaw

Clawpack visualization tools
http://www.clawpack.org
BSD 3-Clause "New" or "Revised" License
29 stars 48 forks source link

change patch.grid.c_edges to c_nodes in frametools.py #158

Closed rjleveque closed 9 years ago

rjleveque commented 9 years ago

due to clawpack/pyclaw#517.

@mandli, @ketch: VisClaw broke and I haven't tested everything, but I think this is the only change needed?

ketch commented 9 years ago

After some grepping, I found that spot and no others, so I think you're right.

ketch commented 9 years ago

Although it shouldn't be broken -- it should just give a deprecation warning.

ketch commented 9 years ago

My mistake -- see https://github.com/clawpack/pyclaw/pull/518. In any case, it's good that we're updating visclaw to the new names. We need to update the docs too; I'll do that. What about the other packages?

rjleveque commented 9 years ago

I don't think any other packages would use this.

ketch commented 9 years ago

Regarding the docs, it turns out we have no documentation on this outside of docstrings. I will add some in the future, but we're fine as far as releasing 5.3.0.