search

clawpack / visclaw

Clawpack visualization tools
http://www.clawpack.org
BSD 3-Clause "New" or "Revised" License
29 stars 47 forks source link

Matlab donna #178

Closed donnaaboise closed 8 years ago

donnaaboise commented 8 years ago

Some minor changes to Matlab graphics, including fix to 'setopengl', so that it compares to lower case selection only.

mandli commented 8 years ago

This looks fine to me, I take it these are all just minor bug fixes that have built up over time?

donnaaboise commented 8 years ago

Yes - that’s right. Minor changes only. But hold off - that PR didn’t have master merged in. I’ll issue a new PR.

On Apr 29, 2016, at 12:40 PM, Kyle Mandli notifications@github.com wrote:

This looks fine to me, I take it these are all just minor bug fixes that have built up over time?

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/clawpack/visclaw/pull/178#issuecomment-215843304

donnaaboise commented 8 years ago

Okay - I issued a new PR - But the Matlab changes are the same.

mandli commented 8 years ago

Where did you issue the PR to? I only see this one still.

donnaaboise commented 8 years ago

I tried issuing a new (third?) PR, but it seems that it doesn't do anything. Maybe because the original PR merged with master without conflicts, so successive PRs don't do anything? Go ahead and merge.