search

clawpack / visclaw

Clawpack visualization tools
http://www.clawpack.org
BSD 3-Clause "New" or "Revised" License
29 stars 48 forks source link

Update changes to KML plotting capabilities #196

Closed donnaaboise closed 7 years ago

donnaaboise commented 7 years ago

Updated code that reads in gauges.data file. Anything after the actual gauge data (t1,t2,x1,x2) is ignored.

mandli commented 7 years ago

The code you wrote (python) looks ok but why not use the Gauges class instead so that if changes are made to the format you won't have to update again?

donnaaboise commented 7 years ago

I guess I didn't know there was a gauges class. Sounds like it would be much simpler. We'll fix that and reissue the PR. Thanks.

mandli commented 7 years ago

It was added with the changes to the format so probably no reason you would have known. Let me know if you need help using it.

donnaaboise commented 7 years ago

I am closing this PR - Melody fixed the Gauges issue (which now uses the Gauges class) and so that will replace this one. I'll issue a new one for the Matlab changes.