search

clawpack / visclaw

Clawpack visualization tools
http://www.clawpack.org
BSD 3-Clause "New" or "Revised" License
29 stars 47 forks source link

Use JSAnimation directly from matplotlib #223

Closed ketch closed 5 years ago

ketch commented 6 years ago

I discovered today that JSAnimation was merged into matplotlib version 2.1, last fall. We should switch over to using this. As far as I can tell, they fixed the issue where you would sometimes get a javascript error instead of the animation (hooray!) You will need to update to matplotlib 2.1+ for this to work. There is a modified version of animation_tools.py in clawpack/riemann_book (currently in a PR) that can be backported to visclaw (and we can delete the JSAnimation directory).

mandli commented 6 years ago

I am glad this capability has been merged in and we don't need to keep our own version (which is behind the newest version as well).

ketch commented 6 years ago

Any opinions on when to make this change? It will break things for people using Matplotlib < 2.1.0, which was released in October 2017. I think it would be nice to include this change in the next release of Clawpack, which I guess is coming very soon.

mandli commented 6 years ago

+1.

rjleveque commented 6 years ago

I started looking into this and ran into some issues with the way we use JSAnimation in plotpages.py, but I'll look at it again today...

ketch commented 6 years ago

If you have a branch and want to push it and mention what's not working, I can also take a look.

rjleveque commented 5 years ago

Closing this issue for now since we ran into problems using JSAnimation from mpl. Something to consider again in the future perhaps..