search

clawpack / visclaw

Clawpack visualization tools
http://www.clawpack.org
BSD 3-Clause "New" or "Revised" License
29 stars 47 forks source link

Animation improvements #260

Closed rjleveque closed 4 years ago

rjleveque commented 4 years ago

I think I finally got the anim.to_jshtml working better so the quality of animations on html pages created by make plots is much better than what's shown in #245. I'm not sure why, since I am now calling a function from animation_tools that does (I think) essentially exactly the same thing as the earlier code, but somehow it works better. I still don't completely understand what's going on.

Anyway, I have now removed the dependence on our old JSAnimation completely and just use what's built in to matplotlib. So this won't work with old versions of matplotlib, but since we are now only supporting Python3 officially I think this is ok?

Others should try it out and let me know about any problems before merging.

This PR also includes several changes to animation_tools to fix some things that were broke and to give greater functionality. I've also been testing this on some notebooks, in particular some in the apps repository and I'll do a PR for those.

This could still use some cleaning up, at some point.

ketch commented 4 years ago

Thanks for revisiting this -- it will be really nice to rely directly matplotlib for this. I don't have time to do testing right now but I did look quickly through the code and it makes sense to me.

mandli commented 4 years ago

Works fine for me, thanks @rjleveque!