clawpack / visclaw

Clawpack visualization tools
http://www.clawpack.org
BSD 3-Clause "New" or "Revised" License
29 stars 47 forks source link

Respect plotdata.html_index_fname #264

Closed rjleveque closed 4 years ago

rjleveque commented 4 years ago

rather than hardwiring _PlotIndex.html on movie page

mjberger commented 4 years ago

what is the motivation for this?

On Apr 15, 2020, at 11:25 AM, Randall J. LeVeque notifications@github.com wrote:

rather than hardwiring _PlotIndex.html on movie page

You can view, comment on, or merge this pull request online at:

https://github.com/clawpack/visclaw/pull/264 https://github.com/clawpack/visclaw/pull/264 Commit Summary

Respect plotdata.html_index_fname rather than hardwiring _PlotIndex.html on movie page File Changes

M src/python/visclaw/plotpages.py https://github.com/clawpack/visclaw/pull/264/files#diff-7a09f172d8e36d1f0e28069a19b733c7 (3) Patch Links:

https://github.com/clawpack/visclaw/pull/264.patch https://github.com/clawpack/visclaw/pull/264.patch https://github.com/clawpack/visclaw/pull/264.diff https://github.com/clawpack/visclaw/pull/264.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/clawpack/visclaw/pull/264, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGUGCYIWRUCTPBB7UJUICDRMXGVBANCNFSM4MIVLOAQ.

rjleveque commented 4 years ago

The user can set this in setplot.py and it was already respected everywhere but in the movie pages.

Usually the default _PlotIndex.html works fine but I discovered when pushing examples to github for documentation pages that links starting with underscore don't always work.