clawpack / visclaw

Clawpack visualization tools
http://www.clawpack.org
BSD 3-Clause "New" or "Revised" License
29 stars 48 forks source link

Update ianimate to work with Matplotlib only (no more JSanimation). #287

Closed ketch closed 2 years ago

ketch commented 2 years ago

Today I found that this doesn't work (running https://github.com/clawpack/apps/blob/master/notebooks/pyclaw/Acoustics-1D.ipynb). I've revised it to stop using visclaw.JSAnimation. I think we should probably delete that, as it likely is broken in other contexts.

rjleveque commented 2 years ago

Yes, we stopped using JSAnimation in other places (plotpages.py, animation_tools.py) and notebooks like this one, but I missed this usage.

I agree we should remove the JSAnimation subdirectory since it's no longer used. I can do a PR for that.