search

claws / BH1750

An Arduino library for the digital light sensor breakout boards containing the BH1750FVI IC
MIT License
252 stars 108 forks source link

Update BH1750.cpp #66

Closed schaeferpm closed 4 years ago

schaeferpm commented 4 years ago

The configure method always pushed the old configuration to the device. Fixed that.

thijstriemstra commented 4 years ago

+1, ping @claws Without this fix I was getting -1 values for some reason..

ps. @schaeferpm this pull request has branch conflict, can you update it?

claws commented 4 years ago

Hey @schaeferpm, I'm keen to apply your change but I just merged a PR that slightly modified the file layout. Are you able to rebase your change? The main change for you to know about is that the file you modified is now in the 'src' directory.

schaeferpm commented 4 years ago

@claws since it was a single line change I wouldn't mind if you had done it.

But now I updated the patch and hope this works.

thijstriemstra commented 4 years ago

thanks. Can this be released?