search

claws / BH1750

An Arduino library for the digital light sensor breakout boards containing the BH1750FVI IC
MIT License
252 stars 108 forks source link

BH1750 MTreg min is 31 in the datasheet, #78

Closed beta-tester closed 2 years ago

beta-tester commented 2 years ago

https://github.com/claws/BH1750/blob/37068ca0984ff60f29c2550c7cd674c1c6247bb9/src/BH1750.cpp#L141 https://github.com/claws/BH1750/blob/37068ca0984ff60f29c2550c7cd674c1c6247bb9/src/BH1750.cpp#L147 a value of 31 will be rejected by your library, but in the datasheet min is 31 and should not be rejected. bh1740_mtreg_range

beta-tester commented 2 years ago

i created a pull request: https://github.com/claws/BH1750/pull/79

beta-tester commented 2 years ago

thank you for merging.