search

claws / BH1750

An Arduino library for the digital light sensor breakout boards containing the BH1750FVI IC
MIT License
248 stars 107 forks source link

Unified sensor #84

Open lefty01 opened 1 year ago

lefty01 commented 1 year ago

maybe you want to add the adafruit unified sensor api as well ... I found it quiet useful.

coelner commented 1 year ago

This should be separated into its own class. Otherwise everyone has to use adafruit unified sensor api in their compile chain. Even if you do not need them, it will use space.

lefty01 commented 1 year ago

ok ... good point, let me see if I can rework it. but would you accept some additional class here within this repo. eg. BH1750_Unified or something? Too me sounds like having a separate library module (repository bases on this one) might then be more appropriate ... but still with some name suffix?

coelner commented 1 year ago

Well it is @claws library, not mine. I'm not sure, if there is a nice way. I'm definitely not into good c++ development, but I guess it could be done like this more or less: https://github.com/finitespace/BME280/blob/master/src/BME280I2C_BRZO.cpp