claws / aioprometheus

A Prometheus Python client library for asyncio-based applications
176 stars 21 forks source link

Make aiohttp dependency optional #37

Closed pirogoeth closed 4 years ago

pirogoeth commented 4 years ago

Includes:


@claws let me know if there is anything I missed or if you have any concerns, thanks! :)

claws commented 4 years ago

Looks mostly there. A few things...

Could you run the dev guide (in docs/dev/index.rst) on your beanch to confirm they still work as written? Specifically:

pirogoeth commented 4 years ago

@claws Do you think it would be reasonable to have the pip install -r requirements.dev.txt install the complete development environment by including -e .[aiohttp] in the requirements.dev.txt itself?

I've added a commit which introduces the above. If you don't like it, I've no qualms reverting and adjusting the documentation accordingly :)

claws commented 4 years ago

I have push a new release of aioprometheus (19.11.0) to PyPI which contains your changes.