claws / aioprometheus

A Prometheus Python client library for asyncio-based applications
176 stars 21 forks source link

Add support for grouping key #45

Closed ods closed 4 years ago

claws commented 4 years ago

Thanks for the proposed change.

I see you have updated test code which is great but I don't see where the new grouping feature is checked. It still seems to be the job name like it already was. Could you add a test for the group key addition that uses the new grouping_key argument and then check the expected outcome is produced?