coveralls
commented
4 years ago Pull Request Test Coverage Report for Build 2412
- 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage remained the same at 100.0%
| Totals | |
|---|---|
| Change from base Build 2407: | 0.0% |
| Covered Lines: | 4145 |
| Relevant Lines: | 4145 |
When a page does not exist (ie. 404) Amphora was producing an ERROR-level (50) message. This devalued the meaning of the ERROR level by polluting logs with errors for things like requests to '/favicon' that browsers automatically make.
A 404 is not an error, it's expected behavior. I think INFO is a suitable level for 404s because they are mostly noise; no additional value is provided to what one can glean from making a client-side request.