search

clay / amphora

Middleware for Express that composes components into renderable pages
https://claycms.gitbooks.io/amphora/
MIT License
31 stars 23 forks source link

remove unused dependency #683

Closed macgyver closed 2 years ago

macgyver commented 4 years ago

I was just chatting with Jordan about handlebars version disparities across the clay ecosystem and noticed that amphora specifies a handlebars dependency but never requires the library, and the tests all pass when it's removed - so that's what this PR does!

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 2442

Totals Coverage Status
Change from base Build 2440: 0.0%
Covered Lines: 4178
Relevant Lines: 4178
💛 - Coveralls
jpope19 commented 3 years ago

@macgyver We've been trying to get rid of all of the handlebars versioning disparities across all of the repos. It's been a bit more difficult than expected:

I'm pretty sure there are 4-5 PRs out there to fix this across other repos but these are the two I know of off the top of my head.

https://github.com/clay/amphora-html/pull/79 https://github.com/clay/clay-kiln/pull/1495

And working to get the starter back up and running with this fixed. It will be done eventually. Not sure if this was done to limit the handlebars version used in the other dependencies?

macgyver commented 3 years ago

word, I had a feeling it would be a huge chore. It's a little frustrating that clay only supports one templating language, and moreso that it's a fairly ancient one.

I support this upgrade because of the security fixes but a more future-thinking solution would be to update everything so that Handlebars is a peer dependency defined by the site - handlebars seems to be basically in maintenance mode but they do periodically release security updates, a new security vulnerability could be discovered tomorrow that will invalidate the work you've already done.

On Fri, Sep 25, 2020 at 10:54 AM Jeff Pope notifications@github.com wrote:

@macgyver https://github.com/macgyver We've been trying to get rid of all of the handlebars versioning disparities across all of the repos. It's been a bit more difficult than expected:

I'm pretty sure there are 4-5 PRs out there to fix this across other repos but these are the two I know of off the top of my head.

clay/amphora-html#79 https://github.com/clay/amphora-html/pull/79 clay/clay-kiln#1495 https://github.com/clay/clay-kiln/pull/1495

And working to get the starter back up and running with this fixed. It will be done eventually. Not sure if this was done to limit the handlebars version used in the other dependencies?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/clay/amphora/pull/683#issuecomment-698976654, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAAJCZK5KCNNLTE5OJ2BB3SHSVLRANCNFSM4KMIYN7A .

jpope19 commented 3 years ago

I definitely endorse the extraction of any direct handlebars dependency 100%. should only be one point of entry where you pass in the templating service during amphora initiation.