Closed Tiffachow closed 3 years ago
What is the reasoning for expectNoLogging assertion when there are 400 errors? @jpope19
400 errors are most likely the expected response from clay, ie 404 for page not found, and in this case they'll be logged at the network level. is there a specific instance where a log for a 400 make sense?
The expectNoLogging was applied for the 501 error as well. Is that being logged at the network level? If we want to add response codes there, would we be able to? What files should I be looking at? @jpope19
@mattoberle I updated the tests to fit the changes but now it says it's failing at the coveralls step. Advise?
I'm going to close this out because https://github.com/clay/amphora/pull/694 (which was derived from this branch) was merged.
What is the reasoning for expectNoLogging assertion when there are 400 errors? @jpope19