search

clay / amphora

Middleware for Express that composes components into renderable pages
https://claycms.gitbooks.io/amphora/
MIT License
31 stars 23 forks source link

Add response codes to log when 400 and 500 level errors occur #693

Closed Tiffachow closed 3 years ago

Tiffachow commented 3 years ago

What is the reasoning for expectNoLogging assertion when there are 400 errors? @jpope19

jpope19 commented 3 years ago

What is the reasoning for expectNoLogging assertion when there are 400 errors? @jpope19

400 errors are most likely the expected response from clay, ie 404 for page not found, and in this case they'll be logged at the network level. is there a specific instance where a log for a 400 make sense?

Tiffachow commented 3 years ago

The expectNoLogging was applied for the 501 error as well. Is that being logged at the network level? If we want to add response codes there, would we be able to? What files should I be looking at? @jpope19

Tiffachow commented 3 years ago

@mattoberle I updated the tests to fit the changes but now it says it's failing at the coveralls step. Advise?

mattoberle commented 3 years ago

I'm going to close this out because https://github.com/clay/amphora/pull/694 (which was derived from this branch) was merged.