Add a backward compatible way to detect the screenshots directory in XCode6 / CoreSimulator.

clayallsopp / motion-screenshots

Automatic screenshots for your RubyMotion apps

MIT License

41 stars 2 forks source link

Add a backward compatible way to detect the screenshots directory in XCode6 / CoreSimulator. #6

Closed HealsCodes closed 9 years ago

HealsCodes commented 9 years ago

This PR will fix #3 by looking for the CoreSimulator directory introduced in XC6. If found it..:

will search for the newest app installation
to determine the simulator UUID from it
parse the BackBoard/applicationState.plist to determine the correct sandbox directory
use that path to copy the screenshots from

If not found it will simply use the old method to detect the correct directory. This requires plutil as well as the plist gem but I don't think they should pose big problems on a Mac.

clayallsopp commented 9 years ago

Looks good to me! It looks like merging #5 caused some conflicts

Thanks for digging into this!

HealsCodes commented 9 years ago

Sorry for the inconvenience - I kinda developed the two fixes in parallel (since you could have rejected any of them). I pulled in the latest changes from your upstream and the PR should now go through clean.

clayallsopp commented 9 years ago

Not an inconvenience at all! Thanks for all these fixes, really good work

HealsCodes commented 9 years ago

My pleasure, taking all the screenshots on all the device sizes and in different languages is just so much easier thay way :)

Do you mind doing a micro version bump and pushing out a new version to rubygems?

Am 10.02.2015 um 18:37 schrieb Clay Allsopp notifications@github.com:

Not an inconvenience at all! Thanks for all these fixes, really good work

Reply to this email directly or view it on GitHub.

clayallsopp commented 9 years ago

It is done: https://rubygems.org/gems/motion-screenshots/versions/0.1.1