search

clayallsopp / react.backbone

Plugin for React to make Backbone migration easier
MIT License
839 stars 60 forks source link

Compatibility with React 0.14 #47

Closed einarq closed 8 years ago

einarq commented 9 years ago

React.Backbone is currently using this.getDOMNode, this is deprecated in React 0.14. Will React.Backbone be updated to get rid of this warning?

markijbema commented 9 years ago

If this is important to you I would suggest making a PR. I'm currently not using this project, but are reviewing (not sure about @clayallsopp , but it might well be that this is no issue to him at the moment either).

The code is small enough that it shouldn't be too hard to fix.

einarq commented 9 years ago

So i guess this is not really maintained anymore? Connecting a model directly to a react component is perhaps not considered very good practice anymore? Still useful in some cases though imo.

On 10 Nov 2015, at 13:19, Mark IJbema notifications@github.com wrote:

If this is important to you I would suggest making a PR. I'm currently not using this project, but are reviewing (not sure about @clayallsopp , but it might well be that this is no issue to him at the moment either).

The code is small enough that it shouldn't be too hard to fix.

— Reply to this email directly or view it on GitHub.

markijbema commented 9 years ago

I don't think there's much work going into this project, but since the scope is well-defined that's not needed either imo. I think this is a good example of a project that's "done". I mean, upgrades need to be supported, but I don't think there's a need to add more functionality.

Personally, I've only used this during a transition from backbone to react, and I don't think Backbone maps cleanly to React, so imo it's not a perfect solution. Otoh, I know people who use it and are happy to keep using it.

I wouldn't say it's not maintained either, both @clayallsopp and I participate in issues and PRs, but actually fixing the code myself is no priority for me at least, more so because currently I'm not using react, so I wouldn't implement it as well as someone who does.

clayallsopp commented 8 years ago

Originally fixed by #48, code removed in #51, so warning is gone