search

clayh53 / tufte-jekyll

Minimal Jekyll blog styled to resemble the look and layout of Edward Tufte's books
MIT License
620 stars 206 forks source link

h3 margin-top overridden by .listing #18

Closed gavinmcgimpsey closed 8 years ago

gavinmcgimpsey commented 8 years ago

margin-top is set in tufte.scss, but later, .listing .listing h3 overrides it with a generic margin: 0;

Subheadings on posts have no top margin separating them from headings or previous paragraphs.

clayh53 commented 8 years ago

this margin is only used for the entry listing page to close up the space between post's listings. It should not apply to anything that is not a h3 descendent of an .listing class. On my builds, the headings spacings for a post seems to display properly. Let me know if you find anything different.

ghost commented 8 years ago

Was this a by-product of accidentally leaving tufte.css in the repo?

clayh53 commented 8 years ago

Possibly. I didn't understand about how the Jekyll pipeline worked with SCSS files initially. I had been using Codekit.

On Nov 20, 2015, at 7:11 PM, Nick notifications@github.com wrote:

Was this a by-product of accidentally leaving tufte.css in the repo?

— Reply to this email directly or view it on GitHub.

ghost commented 8 years ago

It's around the same time period... and it seems like a conflict that might arise from having 2 CSS sources.

clayh53 commented 8 years ago

Think this was the CSS problem. Closing for now.