clayh53 / tufte-jekyll

Minimal Jekyll blog styled to resemble the look and layout of Edward Tufte's books
MIT License
627 stars 207 forks source link

A sidenote in a blockquote is pulled in further than it should be from the right hand margin #24

Closed niallrmurphy closed 8 years ago

ghost commented 8 years ago

Please provide more explanation, and maybe a screenshot. How much further in is the sidenote pulled from the right hand margin? What should it be? And how does it appear for you?

niallrmurphy commented 8 years ago

Certainly, sorry. Have a look at the following screenshot:

https://www.dropbox.com/s/mdbcr499jim4izb/Screenshot%202015-12-31%2023.28.25.png?dl=0

You'll see that the bottom half of the screen contains a sidenote which is left-shifted compared to the sidenote visible at the right-hand side.

clayh53 commented 8 years ago

Yep, that is a problem. I'm guessing it has something to with the margin being calculated from the parent element (in this case, the indented blockquote). I'll see if I can figure out how to get that fixed. And of course, anybody else reading this that has already figured it out: please submit the fix and I'll get the repo modified appropriately.

-Clay On Dec 31, 2015, at 6:35 PM, niallrmurphy notifications@github.com wrote:

Certainly, sorry. Have a look at the following screenshot:

https://www.dropbox.com/s/mdbcr499jim4izb/Screenshot%202015-12-31%2023.28.25.png?dl=0

You'll see that the bottom half of the screen contains a sidenote which is left-shifted compared to the sidenote visible at the right-hand side.

— Reply to this email directly or view it on GitHub.

ghost commented 8 years ago

Marginnotes have the same issue. Increasing the negative margin-right should fix it.

ghost commented 8 years ago

Yep, adding this to tufte.scss fixes it:

blockquote .sidenote, blockquote .marginnote {
  margin-right: -79%
}

See http://fullwidthtest.surge.sh/test/ for example of the fix

clayh53 commented 8 years ago

Should be fixed now.