search

clayh53 / tufte-jekyll

Minimal Jekyll blog styled to resemble the look and layout of Edward Tufte's books
MIT License
620 stars 206 forks source link

Header and footer suboptimal on small screens #8

Closed reitzig closed 8 years ago

reitzig commented 8 years ago

I decided to use this pretty theme for my website. After some tinkering, it does what I want it to in my Firefox. On my phone, I get this:

screenshot_2015-09-22-13-53-02

My suggestions:

reitzig commented 8 years ago

Steps to reproduce:

  1. Go here
  2. Resize the browser window to be very narrow.
clayh53 commented 8 years ago

Thanks for pointing this out. I have been amazed at the interest in this little theme. I will add this to the list of things I need to sort out in the CSS. There is also an issue with some of the side-notes at some browser widths that I need to fix.

On Sep 22, 2015, at 8:02 AM, Raphael R. notifications@github.com wrote:

I decided to use this pretty theme for my website. After some tinkering, it does what I want it to in my Firefox. On my phone, I get this:

My suggestions:

The header should extend more gracefully, moving the line beneath the last navigation link. (The problem is probably that nav.group has a fixed height?) The line distance between the social icons is too large. — Reply to this email directly or view it on GitHub.

reitzig commented 8 years ago

Heh, I noticed that the CSS was slightly ... messy.

Once my site stabilizes, I'll try to distill a set of objective (i.e. not taste-specific) fixes out of it.

clayh53 commented 8 years ago

The CSS is a trainwreck at the moment. I just took a look at Dave Leipman's CSS repo for this style and he has added some nice stuff that I would like to incorporate. Things such as real italic and bold font faces, and some modifications to link styling and so forth. I am going to be working on that along with some layout issues.

reitzig commented 8 years ago

Maintainability disturbs me more than design decisions at the moment. The latter is subject to taste, and if I can adapt things, no problem. But currently, it's hard to tell what gets which style.
My advice: have exactly one x { ... } block per element. Redundancies resp. dependencies can be encoded using SASS (or so it appears, I have no experience with the tool).

clayh53 commented 8 years ago

Check out the new version. I changed the header and footers