search

claytantor / zoetic-xumm

A working ReactJS/Tailwinds CSS xApp using the "Universal Xumm API"
MIT License
2 stars 3 forks source link

Change Websocket implementation to include internal version #1

Closed claytantor closed 1 year ago

claytantor commented 1 year ago

Wietse - XRPLLabs/Xumm 3:30 PM https://github.com/claytantor/zoetic-xumm/blob/main/src/App.js#L332

3:30 PM Any specific reason to do a custom Websocket client instead of the one that ships with the lib?

claytantor 3:31 PM Well if I knew that....

Wietse - XRPLLabs/Xumm 3:31 PM :innocent:

claytantor 3:31 PM :stuck_out_tongue_winking_eye:

rapaygo commented 1 year ago

Wietse - XRPLLabs/Xumm 3:52 PM The universal SDK indeed imlements the regular xumm-sdk for this

Updated the sample: https://github.com/XRPL-Labs/XummSDK-React-Demo/blob/main/src/App.tsx

3:53 PM

The universal SDK (alpha, beta, ...) is basically just a promisified wrapper around the three existing environment specific ones

https://github.com/XRPL-Labs/XUMM-SDK#sdkpayloadcreateandsubscribe

xumm-sdk for Xumm API/payload interactions xumm-xapp-sdk for xApp UI interactions xumm-oauth2-pkce for 'web3', OAuth2/implicit/PKCE sign in in the browser

claytantor 9:15 PM createAndSubscribe ok, I will update my implementation to use this before trying to promote out of sandbox...