search

claytongentry / furlex

A structured data extraction tool written in Elixir
https://hex.pm/packages/furlex
Other
44 stars 18 forks source link

Feature/remove mix from production code #15

Closed Luciam91 closed 6 years ago

Luciam91 commented 6 years ago

Firstly just wanna say thanks for the package, saves a fair bit of work!

However, the use of Mix.env in the oembed module means that we're unable to use this in production currently, this PR removes the use of Mix.env() and adds an additional options key for furlex

claytongentry commented 6 years ago

Hey @Luciam91, I appreciate you surfacing this! I agree, bad call on my part to match on Mix.env() like that in the oembed module.

I would actually prefer to solve this with a bypass on the test, and totally get rid of any environment-specific logic segmentation. I've just done that here: https://github.com/claytongentry/furlex/pull/16

v.0.3.2 should include those changes, if you'll give it an update. In light of this, I'm gonna close this PR, but I've got you with the hat tip in the Changelog, and please feel free to open an issue or submit another PR if you find a followup issue! Thanks