search

claytonjn / hass-circadian_lighting

Circadian Lighting custom component for Home Assistant
Apache License 2.0
756 stars 89 forks source link

white_value will be removed from light in Home Assistant Core 2022.9 #198

Closed emontnemery closed 1 year ago

emontnemery commented 1 year ago

white_value will be removed from light in Home Assistant Core 2022.9, which will break this custom component if it's not updated.

Background here: https://github.com/home-assistant/core/pull/76926

98ultimate commented 1 year ago

Obsolete ATTR_WHITE_VALUE removed from my fork: https://github.com/98ultimate/hass-circadian_lighting

claytonjn commented 1 year ago

I'm going to do my best to get a fix for this out this weekend.

@98ultimate I appreciate your help in giving users an immediate fix! It looks like this fix is the only change in your fork, it would be even better if you could submit a Pull Request into this repo rather than linking to your fork (if users switch to your repo then they depend on me pushing updates, and you keeping your repo in sync, rather than getting updates directly)

98ultimate commented 1 year ago

Pull request: https://github.com/claytonjn/hass-circadian_lighting/pull/199

Did not examine your code @claytonjn but could you review nothing broken after removing ATTR_WHITE_VALUE.

claytonjn commented 1 year ago

Thanks @98ultimate, fixed in 2.1.2