search

claytonjn / hass-circadian_lighting

Circadian Lighting custom component for Home Assistant
Apache License 2.0
756 stars 89 forks source link

Add brightness offset to switch configuration variables #53

Open avdz opened 4 years ago

avdz commented 4 years ago

I would like to propose to add offset_brightness to the switch configuration variables as an enhancement.

My personal reason: not all my lights have the same output power. So to have the same brightness everywhere I would like to finetune the brightness with an offset. The most straightforward way would be adding a constant offset. It's easy enough to clip the output to the maximum allowed brightness and keep the offset as min_brightness. This would work for me as I set my min_brightness to 20% anyway. To generalise this approach it's maybe possible to just continue dimming until min_brightness is reached (thus extending the dimming time). Another approach to keep might be to reduce the offset from a certain threshold. So that min_brightness is reached at the same time as the other lights. This approach would increase the dimming speeds. I'm not sure which one would fit best in the whole circadian lighting rhythm theory ;-) You might even use the same approach for #29

mouth4war commented 4 years ago

I'm handling this by grouping dim lights into one switch and bright ones into another, so I can specify differing min and max brightnesses to even them out.

samuellinde commented 4 years ago

I'm handling this by grouping dim lights into one switch and bright ones into another, so I can specify differing min and max brightnesses to even them out.

This is genius, thank you. I never realized I could create multiple switches. 🙈