Closed amaanq closed 3 months ago
yeah, they are important for adding support for other bindings, and in node-ts we switched from nan to napi. If you want, I can update this PR to account for those changes as well if you'd like and update whatever requires manual changes
(to answer briefly, yes they should be committed)
OK, thanks for the clarification. I've added them all, and no manual changes seemed necessary to keep tests passing. 👍
Thank you! FYI it looks like the upgrade from tree-sitter-cli 0.20 → 0.22 required that the
corpus
tests to be moved totest/corpus
. I've pushed a commit that does that, because otherwise CI was passing without actually running any tests.With tree-sitter-cli 0.22, if I run
./node_modules/.bin/tree-sitter generate
, I'm seeing a lot of changes that are not included in this PR (see below).Many of these look like project setup boilerplate, but some of them seem important (I think?): eg the replacement of
nan
withnode-addon-api
, several other changes topackage.json
, and numerous changes to the (already commited) bindings for node and rust inbindings
, plus addition of other bindings.[question] Do you have any comments or context on if those should be committed to the repo? Or should the generated files not be committed because they will/can be regenerated on demand by the cli?