search

claytonrcarter / tree-sitter-phpdoc

PHPDoc grammar for tree-sitter
22 stars 11 forks source link

Start using Releases #40

Open xtrasmal opened 2 months ago

xtrasmal commented 2 months ago

Hi there,

When adding grammars, folks use specific commits to point to. Usually the commit of a release.

id = "php"
name = "PHP"
description = "PHP support."
version = "0.1.3"
schema_version = 1
authors = ["Piotr Osiewicz <piotr@zed.dev>"]
repository = "https://github.com/zed-industries/zed"

[language_servers.intelephense]
name = "Intelephense"
language = "PHP"
language_ids = { PHP = "php"}

[language_servers.phpactor]
name = "Phpactor"
language = "PHP"

[grammars.php]
repository = "https://github.com/tree-sitter/tree-sitter-php"
commit = "a1e0befae61715d9e162529b3c2bfd961d183613"
path = "php"

[grammars.phpdoc]
repository = "https://github.com/claytonrcarter/tree-sitter-phpdoc"
commit = "1d0e255b37477d0ca46f1c9e9268c8fa76c0b3fc"

This is how Zed does it. It would be great to rely on a certain release :)

claytonrcarter commented 1 month ago

Not opposed, but I would need someone to PR a CI workflow so that I can push a tag to create a release, ideally w/ auto changelog, etc. As I understand it, most of the consumers of this project have been fine to just directly reference a SHA directly instead of a release tag. That's what Zed and nvim are doing, as I understand it.

So I don't plan to do this, but would welcome a PR. 😄