clbarnes / arbor-rs

MIT License

0 stars 1 forks source link

Improve design #10

Open clbarnes opened 5 years ago

clbarnes commented 5 years ago

current issues

Arbor mutability means slow results cannot safely be cached
Lots of methods should just take an ArborParser rather than taking bits of it
Class methods on SynapseClustering??
In general, the current design will require a lot of jumping between JS/py and rust

improvements

ArborParser struct constructed from API response; optionally collapse artifactual branches on instantiation, fields should be immutable
ImmutableArbor variant; mutating methods should return a copy (possibly consuming original?)
SynapseClustering takes an (immutable) ArborParser so that all algorithms can be cached
Arbor root should always be set
Methods to return copies of edges, operate on them, and potentially create new arbor from that
7