search

clbarnes / jeiss-convert

Convert Jeiss .dat files to HDF5
MIT License
2 stars 2 forks source link

consider adding ordered list of channel dataset names to attributes #10

Open trautmane opened 1 year ago

trautmane commented 1 year ago

I think it would be useful to add the ordered channel names derived here to a separate attribute so that you can always identify channel order with certainty. The current convention of AI<channel number> with a limit of 5 channels works, but I think adding an explicitly ordered list is more future-proof.

Just a thought ...

clbarnes commented 1 year ago

Agreed, this would make for a good extra attribute in the same vein as the ISO dates and the named enum variants. So long as hdf5 is fine storing an array of strings of variable length, which I think it is. As this is a derived attribute rather than a normative one we could also comfortably strip or pad the original name with null bytes. Something like ChannelNames?

clbarnes commented 1 year ago

Fixed in https://github.com/clbarnes/jeiss-convert/commit/6f912da2f62bfa3d3c364052d381cd8bc1fc05af