search

clbarnes / pixybattle

https://github.com/WomensCodingCircle/pixybattle.git
0 stars 1 forks source link

Non-functional changes for standards compliance #15

Closed clbarnes closed 7 years ago

clbarnes commented 7 years ago

There was inconsistency in the existing code between using camelCase and snake_case for naming functions and variables - for consistency/ principle of minimum surprise, it's better to pick one and stick to it. The official style guidelines suggest snake_case, so I went with that. Note that constants use SCREAMING_SNAKE_CASE, and classes use UpperCamelCase.

I also ran autopep8 to standardise spacing (which also improves readability in some points of the code). Make sure your editors are set to use 4 spaces instead of tabs!

None of these changes should have any effect on the way the code runs.

clbarnes commented 7 years ago

Merging this before anyone gets too deep into starting their stuff.

Remember to git pull team master into whatever branch you're working in!