clbarnes / zarr3-rs

Prototype implementation of zarr v3 in rust
MIT License
18 stars 0 forks source link

Rename endian codec #18

Closed clbarnes closed 1 year ago

clbarnes commented 1 year ago

See https://github.com/zarr-developers/zarr-specs/pull/263

clbarnes commented 1 year ago

To do: improve error handling here. Maybe AB codecs need an endian() method, which ArrayMetadata can access through the CodecChain and check against the dtype - then it's justifiable to leave the undefined endianness at the codec level as a panic rather than making it fallible.

Or this all becomes fine anyway as codec ops probably need to be fallible anyway.

clbarnes commented 1 year ago

Added validation of endianness on arraymetadata construction.

clbarnes commented 1 year ago

Also updates for recent spec changes: