search

clbr / fifth

Fifth is a Linux-exclusive browser that carries the best features from Opera, as well as a few unique features that are likely to please Linux power users. It's based on a custom Webkit port to FLTK and comes licensed under the GPLv3.
GNU General Public License v3.0
108 stars 7 forks source link

dashed and dotted are broken #22

Open szukw000 opened 8 years ago

szukw000 commented 8 years ago

I use fifth-0.5 and webkitfltk-0.5.1. Both borders below are broken. Which file in webkitfltk-0.5.1 draws border lines resp. border styles?

winfried

10px red dashed
Column 1 Column 2
Aaa Aaa Aaa Xxx Xxx Xxx
Bbb Bbb Bbb Yyy Yyy Yyy
Ccc Ccc Ccc Zzz Zzz Zzz
10px blue dotted
Column 1 Column 2
Aaa Aaa Aaa Xxx Xxx Xxx
Bbb Bbb Bbb Yyy Yyy Yyy
Ccc Ccc Ccc Zzz Zzz Zzz
clbr commented 8 years ago

Rendered result: http://imgur.com/tSfiu5h

This is handled entirely by the common webkit code, and so should either affect all webkit browsers or all webkit browsers using cairo. I can't tell offhand which files are involved.

szukw000 commented 8 years ago

I compiled webkitgtk-2.13.4 and found that 'bin/MiniBrowser' does show the borders correctly.

Now I compiled 'surf2' using webkitgtk. It dows show the borders correctly.

Both programs are assumed to use CAIRO.

winfried surf2-borders

szukw000 commented 8 years ago

@clbr, how does this look like? I have changed the file

Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp

winfried dot-dash

szukw000 commented 8 years ago

@clbr , here is the patch.

winfried

GraphicsContextCairo.cpp.dif.zip

clbr commented 8 years ago

This looks like a partial backport with different function name, etc. It would cause code conflicts the next time I sync against upstream webkit.

If it's indeed solved in current webkit, then I'd prefer for larger things like this to happen with the sync. If you need a source with that patch, I'd advise you to make a fork here on github. I can't give a date for when I can do the update, as it takes all day, not sure when I have that much free.

szukw000 commented 8 years ago

@clbr , I do not understand your objections.

The library compiles without error, the result is OK. What do you want more?

winfried

clbr commented 8 years ago

It also has to not make maintenance difficult, ie increase my workload too much.