clbr / radeontop

GNU General Public License v3.0
808 stars 70 forks source link

Add CPU usage on top, merge two VRAM entries #12

Closed strelec closed 9 years ago

strelec commented 10 years ago

First of all, CPU usage is an important information (even if it is not strictly related to GPU). This way you can know what is bottlenecking, CPU or GPU. So it would look like this:

                 radeontop , running on RV710, 120 samples/sec                  
                   CPU utilization 8,12% │
                   Graphics pipe  11,67% │    
─────────────────────────────────────────┼──
                    Event Engine   6,67% │  

Secondly, there are two lines related to VRAM reporting, which consume most precious vertical space. It looks like this at this moment:

                            VRAM  52,12% │                   
                            VRAM    267M │

I'd merge it to look like this:

                     VRAM (267M)  52,12% │                   
clbr commented 10 years ago

On Sat, 02 Aug 2014 06:17:37 -0700 Rok Kralj notifications@github.com wrote:

First of all, CPU usage is an important information (even if it is not strictly related to GPU). This way you can know what is bottlenecking, CPU or GPU. So it would look like this:

                 radeontop , running on RV710, 120 samples/sec                  
                   CPU utilization 8,12% │
                   Graphics pipe  11,67% │    
─────────────────────────────────────────┼──
                    Event Engine   6,67% │  

While it is important, it is just one external variable to correlate with. So I would say having CPU usage here is out of scope, just as temperature, fan speed, io pressure - if you want to correlate against these, please use the dump mode of all needed applications.

The Phoronix Test Suite is able to do this in an automated way - set it to collect cpu usage, gpu usage, and other sensor data, and you will have easily comparable graphs.

Secondly, there are two lines related to VRAM reporting, which consume most precious vertical space. It looks like this at this moment:

                            VRAM  52,12% │                   
                            VRAM    267M │

I'd merge it to look like this:

                     VRAM (267M)  52,12% │                   

Certainly, a good suggestion. Would you like to provide a patch?

strelec commented 10 years ago

Sure. I'll make a pull request.

clbr commented 9 years ago

Fixed by nckx.