clbr / radeontop

GNU General Public License v3.0
810 stars 72 forks source link

Suggestion - Add maximum values in dump mode #120

Open Br31zh opened 3 years ago

Br31zh commented 3 years ago

Hello,

I’m using radeontop in dump mode to use external tools to monitor my GPU. But the dump mode don’t show maximum values, only current and percentage, unlike the interactive mode, so I have to configure the maximum manually for each ghz / mb field (or make a calculation from the percentage, but that’s not really accurate).

Can you add them in the dump mode, so it can be dynamically set?

Thanks.

clbr commented 3 years ago

This would be a breaking change, affecting existing programs using the dump output. So not sure.

Is there something in your use case where the inaccuracy from percentages is too high? Ie, does it matter if the maximum is reported as 1.23GHz when it really was 1.24?

Br31zh commented 3 years ago

This would be a breaking change, affecting existing programs using the dump output. So not sure.

I didn’t take this in consideration, since it was adding fields and not changing or removing existing ones, but after looking again on the dumping output, it’s true that it can break some programs…

Is there something in your use case where the inaccuracy from percentages is too high? Ie, does it matter if the maximum is reported as 1.23GHz when it really was 1.24?

It's not important enough to make breaking changes, at least.