search

clbr / radeontop

GNU General Public License v3.0
785 stars 69 forks source link

Introducing GitHub Actions #125

Closed melroy89 closed 2 years ago

melroy89 commented 2 years ago

Build for free 👍🏽

clbr commented 2 years ago

I'm not sure about this, not sure I want to depend on any particular service.

melroy89 commented 2 years ago

It's just GitHub Actions for your pipeline. Currently it only builds it.. No worries. I think it make sense to check if code in pull requests still compiles. And people who want to use the binary without compiling knowledge can grep the binary.

That being said, it's not a hard dependency. I can also introduce a GitLab CI yaml file if you want.

melroy89 commented 2 years ago

You are not depending on GitHub Actions, its just for your convenience. It's up to you if you really want to fully depend on it. In all cases, you are free to merge this PR.

clbr commented 2 years ago

Thank you for the PR, but I've decided not to merge this.