search

clbr / radeontop

GNU General Public License v3.0
785 stars 69 forks source link

Stop relying on git for getting the version name #150

Open danielzgtg opened 1 year ago

danielzgtg commented 1 year ago

Downstream wants us to do this:

It's not a packaging problem, it's an upstream bug:

The version number is set through the script "getver.sh" which is part of the upstream source tree [1]. Since this script exclusively relies on git to determine the version number and the Debian package is built from the distributed tarball which does not contain any git repository information, there is no way for "getver.sh" to determine the version information from the distributed tarball source.

In order to fix this problem, the upstream developers need to modify the Makefile to generate the version information and write it into "getver.sh" anytime "make dist" is called.

Please report this bug upstream, it's not a packaging bug. Also, the original package is maintained in Debian, not Ubuntu which is why it took a bit longer until me (the package maintainer) saw this bug report.

https://bugs.launchpad.net/ubuntu/+source/radeontop/+bug/1992262

clbr commented 1 year ago

There is no distributed tarball. There was, years ago, but github removed the files option. If they use a third-party-generated git checkout, that is not an official released tarball by us.

clbr commented 1 year ago

See https://bagder.github.io/github-feedback/releases-tarball.html