clbr / radeontop

GNU General Public License v3.0
785 stars 69 forks source link

Add support for RX 7900 XT #153

Open deadmeu opened 1 year ago

deadmeu commented 1 year ago

Running version 1.4 seems to work just fine with the Sapphire RX 7900 XT.

This might help:

> cat /usr/share/hwdata/pci.ids | grep "RX 7900"
744c  Navi 31 [Radeon RX 7900 XT/7900 XTX]
    1da2 e471  NITRO+ RX 7900 XTX Vapor-X

Happy to provide more info or even a PR if someone could let me know the steps required.

clbr commented 1 year ago

Sorry? Did you mean this as a reply somewhere else?

deadmeu commented 1 year ago

Sorry? Did you mean this as a reply somewhere else?

It seems like my card isn't officially supported? Unknown Radeon card. <= R500 won't work, new cards might. I'm just raising a ticket to make it officially supported.

clbr commented 1 year ago

You wrote above it works just fine?

deadmeu commented 1 year ago

I assume it's not preferred for "Unknown Radeon card" and "... running on UNKNOWN_CHIP ..." to be presented to the user?

clbr commented 1 year ago

The pci ids for new cards will eventually be added. It needs a new source as they're no longer updated in the kernel where they were gotten from til now.

Umio-Yasuno commented 1 year ago

The AMDGPU chip can be detected from chip_rev and family_id in amdgpu_gpu_info. The pci id is not required.

Umio-Yasuno commented 1 year ago

Draft: https://github.com/Umio-Yasuno/radeontop/commit/88e2bb526dd66c6a75afe7bf8366e47b2b06bddd

Detection of GFX1036/Raphael, GFX1037/Mendocino, GFX1100/Navi31, GFX1101/Navi32, GFX1102/Navi33, GFX1103_R1/Phoenix, GFX1103_R2/Phoenix .

deadmeu commented 1 year ago

Draft: Umio-Yasuno@88e2bb5

Detection of _GFX1036/Raphael, GFX1037/Mendocino, GFX1100/Navi31, GFX1101/Navi31, GFX1102/Navi33, GFX1103_R1/Phoenix, GFX1103R2/Phoenix .

Nice! This is picking my card up as running on "GFX1101".

Umio-Yasuno commented 1 year ago

Draft: Umio-Yasuno@88e2bb5 Detection of _GFX1036/Raphael, GFX1037/Mendocino, GFX1100/Navi31, GFX1101/Navi31, GFX1102/Navi33, GFX1103_R1/Phoenix, GFX1103R2/Phoenix .

Nice! This is picking my card up as running on "GFX1101".

Oops, GFX1100 was missing in family_str.c.

Fixed: https://github.com/Umio-Yasuno/radeontop/commit/accd6ff513221013bac661fe91fbde4a87c58ca0

deadmeu commented 1 year ago

Oops, GFX1100 was missing in family_str.c.

Fixed: Umio-Yasuno@accd6ff

I'm not sure what the correct code should be, but it is reporting GFX1100 now :slightly_smiling_face:. The version seems to be missing: https://i.imgur.com/sL10Zx2.png

Umio-Yasuno commented 1 year ago

AFAIK, AMD Radeon RX 7900 XT is Navi31 based.

    GFX1100, // Navi31
    GFX1101, // Navi32
    GFX1102, // Navi33
    GFX1103_R1,  // Phoenix
    GFX1103_R2, // Phoenix
    GFX1036, // Raphael
    GFX1037, // Mendocino
Umio-Yasuno commented 1 year ago

I am currently developing software in the Rust language that will be the successor to radeontop. https://github.com/Umio-Yasuno/amdgpu_top

@clbr is busy and radeontop has issues such as reporting deleted values on Vega/GFX9/soc15 and Navi/GFX10.

https://github.com/clbr/radeontop/pull/93