clbr / radeontop

GNU General Public License v3.0
804 stars 70 forks source link

Add card number option for when multiple cards are on same bus #56

Closed chipfreitag closed 6 years ago

clbr commented 6 years ago

Is it possible for two pcie cards to be on the same bus? Where does this happen?

Notes on the patch:

chipfreitag commented 6 years ago

Thanks for the quick review. Yes sorry about the sloppy printfs and the notes in the READM. I should not have included those.

In the past I have used the –b option to select from multiple adaptors. I was not able to do so recently, but this morning discovered that your interface does work, you just have to enter a decimal number for the device you want.

I will withdraw the pull request. One enhancement I have made (locally) Is to include the busid string in the printcenter for the screen header. This way I can see exactly which device has been chosen.

From: clbr [mailto:notifications@github.com] Sent: Tuesday, January 23, 2018 3:00 AM To: clbr/radeontop radeontop@noreply.github.com Cc: Freitag, Chip chip.freitag@amd.com; Author author@noreply.github.com Subject: Re: [clbr/radeontop] Add card number option for when multiple cards are on same bus (#56)

Is it possible for two pcie cards to be on the same bus? Where does this happen?

Notes on the patch:

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/clbr/radeontop/pull/56#issuecomment-359723573, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AE-2BirDGsF83nnkr6aCLp8RdpqJ4pYNks5tNZ99gaJpZM4Roped.