clbustos / statsample

A suite for basic and advanced statistics on Ruby.
http://github.com/clbustos/statsample
BSD 3-Clause "New" or "Revised" License
402 stars 96 forks source link

Removed MLE #31

Closed v0dro closed 10 years ago

clbustos commented 10 years ago

This should be created on another branch, until we can release a flawless release.

Don't delete the test_cases!!! These should be adapted to new API.

v0dro commented 10 years ago

I've added test cases for GLM in statsample-glm. They are in RSpec and look much cleaner. For example, all data is loaded from files and nothing is simulated in code (which I think looks messy).

Is that fine or should I add the test files again?

ukd1 commented 10 years ago

@v0dro the build is failing - can you find out why?

v0dro commented 10 years ago

@ukd1 Hadnt removed require's. Works fine now. Please evaluate this and also https://github.com/SciRuby/statsample-glm/pull/2

djdarkbeat commented 10 years ago

Hi claudia,

I have a couple work committments this week that are a full day’s engagement. I can look at this tomorrow morning.

Brian

Brian Loomis (208) 336-2586 http://www.customated.com

On Wednesday, September 24, 2014 at 10:05 PM, Sameer Deshmukh wrote:

@ukd1 (https://github.com/ukd1) Hadnt removed require's. Works fine now. Please evaluate this and also SciRuby/statsample-glm#2 (https://github.com/SciRuby/statsample-glm/pull/2)

— Reply to this email directly or view it on GitHub (https://github.com/clbustos/statsample/pull/31#issuecomment-56771417).

v0dro commented 10 years ago

Thank you. I will send an update for the README in a short while.